Read-only mirror — the public repositories of the Forgejo instance, refreshed every 10 minutes. The live instance (fg.dieschoenewolke.de) is reachable only over the VPN; clone here with https://git.dieschoenewolke.de/git/<owner>/<repo>.git.
summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authoreric sciple <ericsciple@users.noreply.github.com>2019-12-12 14:04:04 -0500
committerGitHub <noreply@github.com>2019-12-12 14:04:04 -0500
commit71919ee93524634437555282897c443247b4b33d (patch)
tree3c3326ffb6fd86cfd6ff274b08879e6ffa4fa77a /src
parentca3a763d5ed9e04331c8a6aea85ddabcb3a6aa4d (diff)
do not pass cred on command line (#108)v2-beta
Diffstat (limited to 'src')
-rw-r--r--src/git-source-provider.ts30
1 files changed, 25 insertions, 5 deletions
diff --git a/src/git-source-provider.ts b/src/git-source-provider.ts
index 6b7a9f7..8c7aa15 100644
--- a/src/git-source-provider.ts
+++ b/src/git-source-provider.ts
@@ -259,14 +259,34 @@ async function configureAuthToken(
git: IGitCommandManager,
authToken: string
): Promise<void> {
- // Add extraheader (auth)
- const base64Credentials = Buffer.from(
+ // Configure a placeholder value. This approach avoids the credential being captured
+ // by process creation audit events, which are commonly logged. For more information,
+ // refer to https://docs.microsoft.com/en-us/windows-server/identity/ad-ds/manage/component-updates/command-line-process-auditing
+ const placeholder = `AUTHORIZATION: basic ***`
+ await git.config(authConfigKey, placeholder)
+
+ // Determine the basic credential value
+ const basicCredential = Buffer.from(
`x-access-token:${authToken}`,
'utf8'
).toString('base64')
- core.setSecret(base64Credentials)
- const authConfigValue = `AUTHORIZATION: basic ${base64Credentials}`
- await git.config(authConfigKey, authConfigValue)
+ core.setSecret(basicCredential)
+
+ // Replace the value in the config file
+ const configPath = path.join(git.getWorkingDirectory(), '.git', 'config')
+ let content = (await fs.promises.readFile(configPath)).toString()
+ const placeholderIndex = content.indexOf(placeholder)
+ if (
+ placeholderIndex < 0 ||
+ placeholderIndex != content.lastIndexOf(placeholder)
+ ) {
+ throw new Error('Unable to replace auth placeholder in .git/config')
+ }
+ content = content.replace(
+ placeholder,
+ `AUTHORIZATION: basic ${basicCredential}`
+ )
+ await fs.promises.writeFile(configPath, content)
}
async function removeGitConfig(