<feed xmlns='http://www.w3.org/2005/Atom'>
<title>janschoenfeld/checkout.git/src, branch ericsciple-patch-1</title>
<subtitle>Action for checking out a repo
</subtitle>
<link rel='alternate' type='text/html' href='http://git.dieschoenewolke.de/janschoenfeld/checkout.git/'/>
<entry>
<title>Update main.ts</title>
<updated>2021-07-12T16:06:24+00:00</updated>
<author>
<name>eric sciple</name>
<email>ericsciple@users.noreply.github.com</email>
</author>
<published>2021-07-12T16:06:24+00:00</published>
<link rel='alternate' type='text/html' href='http://git.dieschoenewolke.de/janschoenfeld/checkout.git/commit/?id=79b23cb944e62b9e71e69fd9af780fccc7465abf'/>
<id>79b23cb944e62b9e71e69fd9af780fccc7465abf</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Add missing `await`s (#379)</title>
<updated>2020-11-03T14:44:09+00:00</updated>
<author>
<name>Johannes Schindelin</name>
<email>dscho@github.com</email>
</author>
<published>2020-11-03T14:44:09+00:00</published>
<link rel='alternate' type='text/html' href='http://git.dieschoenewolke.de/janschoenfeld/checkout.git/commit/?id=2267990cd9bb5381259f49c66a8476d75f41e36e'/>
<id>2267990cd9bb5381259f49c66a8476d75f41e36e</id>
<content type='text'>
* auth-helper: properly await replacement of the token value in the config

After writing the `.extraheader` config, we manually replace the token
with the actual value. This is done in an `async` function, but we were
not `await`ing the result.

In our tests, this commit fixes a flakiness we observed where
`remote.origin.url` sometimes (very rarely, actually) is not set for
submodules. Our interpretation is that the configs are in the process of
being rewritten with the correct token value _while_ another `git
config` that wants to set the `insteadOf` value is reading the config,
which is currently empty.

A more idiomatic way to fix this in Typescript would use
`Promise.all()`, like this:

      await Promise.all(
        configPaths.map(async configPath =&gt; {
          core.debug(`Replacing token placeholder in '${configPath}'`)
          await this.replaceTokenPlaceholder(configPath)
        })
      )

However, during review of https://github.com/actions/checkout/pull/379
it was decided to keep the `for` loop in the interest of simplicity.

Reported by Ian Lynagh.

Signed-off-by: Johannes Schindelin &lt;johannes.schindelin@gmx.de&gt;

* downloadRepository(): await the result of recursive deletions

Signed-off-by: Johannes Schindelin &lt;johannes.schindelin@gmx.de&gt;

* Ask ESLint to report floating Promises

This rule is quite helpful in avoiding hard-to-debug missing `await`s.

Note: there are two locations in `src/main.ts` that trigger warnings:
the `run()` and the `cleanup()` function are called without `await` and
without any `.catch()` clause.

In the initial version of https://github.com/actions/checkout/pull/379,
this was addressed by adding `.catch()` clauses. However, it was
determined that this is boilerplate code that will need to be fixed in a
broader way.

Signed-off-by: Johannes Schindelin &lt;johannes.schindelin@gmx.de&gt;

* Rebuild

This trick was brought to you by `npm ci &amp;&amp; npm run build`. Needed to
get the PR build to pass.

Signed-off-by: Johannes Schindelin &lt;johannes.schindelin@gmx.de&gt;</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
* auth-helper: properly await replacement of the token value in the config

After writing the `.extraheader` config, we manually replace the token
with the actual value. This is done in an `async` function, but we were
not `await`ing the result.

In our tests, this commit fixes a flakiness we observed where
`remote.origin.url` sometimes (very rarely, actually) is not set for
submodules. Our interpretation is that the configs are in the process of
being rewritten with the correct token value _while_ another `git
config` that wants to set the `insteadOf` value is reading the config,
which is currently empty.

A more idiomatic way to fix this in Typescript would use
`Promise.all()`, like this:

      await Promise.all(
        configPaths.map(async configPath =&gt; {
          core.debug(`Replacing token placeholder in '${configPath}'`)
          await this.replaceTokenPlaceholder(configPath)
        })
      )

However, during review of https://github.com/actions/checkout/pull/379
it was decided to keep the `for` loop in the interest of simplicity.

Reported by Ian Lynagh.

Signed-off-by: Johannes Schindelin &lt;johannes.schindelin@gmx.de&gt;

* downloadRepository(): await the result of recursive deletions

Signed-off-by: Johannes Schindelin &lt;johannes.schindelin@gmx.de&gt;

* Ask ESLint to report floating Promises

This rule is quite helpful in avoiding hard-to-debug missing `await`s.

Note: there are two locations in `src/main.ts` that trigger warnings:
the `run()` and the `cleanup()` function are called without `await` and
without any `.catch()` clause.

In the initial version of https://github.com/actions/checkout/pull/379,
this was addressed by adding `.catch()` clauses. However, it was
determined that this is boilerplate code that will need to be fixed in a
broader way.

Signed-off-by: Johannes Schindelin &lt;johannes.schindelin@gmx.de&gt;

* Rebuild

This trick was brought to you by `npm ci &amp;&amp; npm run build`. Needed to
get the PR build to pass.

Signed-off-by: Johannes Schindelin &lt;johannes.schindelin@gmx.de&gt;</pre>
</div>
</content>
</entry>
<entry>
<title>Remove unneeded commit information from build logs (#345)</title>
<updated>2020-09-23T13:41:47+00:00</updated>
<author>
<name>Thomas Boop</name>
<email>52323235+thboop@users.noreply.github.com</email>
</author>
<published>2020-09-23T13:41:47+00:00</published>
<link rel='alternate' type='text/html' href='http://git.dieschoenewolke.de/janschoenfeld/checkout.git/commit/?id=6943eced8faa00b363a577a3e573551e2255efac'/>
<id>6943eced8faa00b363a577a3e573551e2255efac</id>
<content type='text'>
* Remove unneeded commit information from stdout
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
* Remove unneeded commit information from stdout
</pre>
</div>
</content>
</entry>
<entry>
<title>update default branch (#305)</title>
<updated>2020-07-14T13:23:30+00:00</updated>
<author>
<name>eric sciple</name>
<email>ericsciple@users.noreply.github.com</email>
</author>
<published>2020-07-14T13:23:30+00:00</published>
<link rel='alternate' type='text/html' href='http://git.dieschoenewolke.de/janschoenfeld/checkout.git/commit/?id=b92a2fe2f4e41a6409f8d7fa0c3ed391f54d0c2d'/>
<id>b92a2fe2f4e41a6409f8d7fa0c3ed391f54d0c2d</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>fix default branch for .wiki and when using ssh (#284)</title>
<updated>2020-06-18T14:20:33+00:00</updated>
<author>
<name>eric sciple</name>
<email>ericsciple@users.noreply.github.com</email>
</author>
<published>2020-06-18T14:20:33+00:00</published>
<link rel='alternate' type='text/html' href='http://git.dieschoenewolke.de/janschoenfeld/checkout.git/commit/?id=b8cb77a290d6bf1500962ef3fdb92249d45b0ac6'/>
<id>b8cb77a290d6bf1500962ef3fdb92249d45b0ac6</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>determine default branch (#278)</title>
<updated>2020-06-16T17:41:01+00:00</updated>
<author>
<name>eric sciple</name>
<email>ericsciple@users.noreply.github.com</email>
</author>
<published>2020-06-16T17:41:01+00:00</published>
<link rel='alternate' type='text/html' href='http://git.dieschoenewolke.de/janschoenfeld/checkout.git/commit/?id=17570e7adbcebf582c615bdac7f07339940d90e3'/>
<id>17570e7adbcebf582c615bdac7f07339940d90e3</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Fetch all history for all tags and branches when fetch-depth=0 (#258)</title>
<updated>2020-05-27T13:54:28+00:00</updated>
<author>
<name>eric sciple</name>
<email>ericsciple@users.noreply.github.com</email>
</author>
<published>2020-05-27T13:54:28+00:00</published>
<link rel='alternate' type='text/html' href='http://git.dieschoenewolke.de/janschoenfeld/checkout.git/commit/?id=1af3b46e902378dcbdf104a32ddae1644c64c366'/>
<id>1af3b46e902378dcbdf104a32ddae1644c64c366</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>telemetry for incorrect merge commit (#253)</title>
<updated>2020-05-21T15:09:16+00:00</updated>
<author>
<name>eric sciple</name>
<email>ericsciple@users.noreply.github.com</email>
</author>
<published>2020-05-21T15:09:16+00:00</published>
<link rel='alternate' type='text/html' href='http://git.dieschoenewolke.de/janschoenfeld/checkout.git/commit/?id=31d9f35c90667154e76ccca096898caab3e5bba7'/>
<id>31d9f35c90667154e76ccca096898caab3e5bba7</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>switch GITHUB_URL to GITHUB_SERVER_URL (#248)</title>
<updated>2020-05-18T17:05:15+00:00</updated>
<author>
<name>eric sciple</name>
<email>ericsciple@users.noreply.github.com</email>
</author>
<published>2020-05-18T17:05:15+00:00</published>
<link rel='alternate' type='text/html' href='http://git.dieschoenewolke.de/janschoenfeld/checkout.git/commit/?id=668d86fc619a391e755581af86c427e216494727'/>
<id>668d86fc619a391e755581af86c427e216494727</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>consume new @actions/github for GHES support (#236)</title>
<updated>2020-05-07T16:11:11+00:00</updated>
<author>
<name>eric sciple</name>
<email>ericsciple@users.noreply.github.com</email>
</author>
<published>2020-05-07T16:11:11+00:00</published>
<link rel='alternate' type='text/html' href='http://git.dieschoenewolke.de/janschoenfeld/checkout.git/commit/?id=e55727d418e99c52db29fa5e822f0eb64ce9b1ca'/>
<id>e55727d418e99c52db29fa5e822f0eb64ce9b1ca</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
</feed>
