<feed xmlns='http://www.w3.org/2005/Atom'>
<title>janschoenfeld/checkout.git/src/git-auth-helper.ts, branch ericsciple-patch-1</title>
<subtitle>Action for checking out a repo
</subtitle>
<link rel='alternate' type='text/html' href='http://git.dieschoenewolke.de/janschoenfeld/checkout.git/'/>
<entry>
<title>Add missing `await`s (#379)</title>
<updated>2020-11-03T14:44:09+00:00</updated>
<author>
<name>Johannes Schindelin</name>
<email>dscho@github.com</email>
</author>
<published>2020-11-03T14:44:09+00:00</published>
<link rel='alternate' type='text/html' href='http://git.dieschoenewolke.de/janschoenfeld/checkout.git/commit/?id=2267990cd9bb5381259f49c66a8476d75f41e36e'/>
<id>2267990cd9bb5381259f49c66a8476d75f41e36e</id>
<content type='text'>
* auth-helper: properly await replacement of the token value in the config

After writing the `.extraheader` config, we manually replace the token
with the actual value. This is done in an `async` function, but we were
not `await`ing the result.

In our tests, this commit fixes a flakiness we observed where
`remote.origin.url` sometimes (very rarely, actually) is not set for
submodules. Our interpretation is that the configs are in the process of
being rewritten with the correct token value _while_ another `git
config` that wants to set the `insteadOf` value is reading the config,
which is currently empty.

A more idiomatic way to fix this in Typescript would use
`Promise.all()`, like this:

      await Promise.all(
        configPaths.map(async configPath =&gt; {
          core.debug(`Replacing token placeholder in '${configPath}'`)
          await this.replaceTokenPlaceholder(configPath)
        })
      )

However, during review of https://github.com/actions/checkout/pull/379
it was decided to keep the `for` loop in the interest of simplicity.

Reported by Ian Lynagh.

Signed-off-by: Johannes Schindelin &lt;johannes.schindelin@gmx.de&gt;

* downloadRepository(): await the result of recursive deletions

Signed-off-by: Johannes Schindelin &lt;johannes.schindelin@gmx.de&gt;

* Ask ESLint to report floating Promises

This rule is quite helpful in avoiding hard-to-debug missing `await`s.

Note: there are two locations in `src/main.ts` that trigger warnings:
the `run()` and the `cleanup()` function are called without `await` and
without any `.catch()` clause.

In the initial version of https://github.com/actions/checkout/pull/379,
this was addressed by adding `.catch()` clauses. However, it was
determined that this is boilerplate code that will need to be fixed in a
broader way.

Signed-off-by: Johannes Schindelin &lt;johannes.schindelin@gmx.de&gt;

* Rebuild

This trick was brought to you by `npm ci &amp;&amp; npm run build`. Needed to
get the PR build to pass.

Signed-off-by: Johannes Schindelin &lt;johannes.schindelin@gmx.de&gt;</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
* auth-helper: properly await replacement of the token value in the config

After writing the `.extraheader` config, we manually replace the token
with the actual value. This is done in an `async` function, but we were
not `await`ing the result.

In our tests, this commit fixes a flakiness we observed where
`remote.origin.url` sometimes (very rarely, actually) is not set for
submodules. Our interpretation is that the configs are in the process of
being rewritten with the correct token value _while_ another `git
config` that wants to set the `insteadOf` value is reading the config,
which is currently empty.

A more idiomatic way to fix this in Typescript would use
`Promise.all()`, like this:

      await Promise.all(
        configPaths.map(async configPath =&gt; {
          core.debug(`Replacing token placeholder in '${configPath}'`)
          await this.replaceTokenPlaceholder(configPath)
        })
      )

However, during review of https://github.com/actions/checkout/pull/379
it was decided to keep the `for` loop in the interest of simplicity.

Reported by Ian Lynagh.

Signed-off-by: Johannes Schindelin &lt;johannes.schindelin@gmx.de&gt;

* downloadRepository(): await the result of recursive deletions

Signed-off-by: Johannes Schindelin &lt;johannes.schindelin@gmx.de&gt;

* Ask ESLint to report floating Promises

This rule is quite helpful in avoiding hard-to-debug missing `await`s.

Note: there are two locations in `src/main.ts` that trigger warnings:
the `run()` and the `cleanup()` function are called without `await` and
without any `.catch()` clause.

In the initial version of https://github.com/actions/checkout/pull/379,
this was addressed by adding `.catch()` clauses. However, it was
determined that this is boilerplate code that will need to be fixed in a
broader way.

Signed-off-by: Johannes Schindelin &lt;johannes.schindelin@gmx.de&gt;

* Rebuild

This trick was brought to you by `npm ci &amp;&amp; npm run build`. Needed to
get the PR build to pass.

Signed-off-by: Johannes Schindelin &lt;johannes.schindelin@gmx.de&gt;</pre>
</div>
</content>
</entry>
<entry>
<title>group output (#191)</title>
<updated>2020-03-27T17:12:15+00:00</updated>
<author>
<name>eric sciple</name>
<email>ericsciple@users.noreply.github.com</email>
</author>
<published>2020-03-27T17:12:15+00:00</published>
<link rel='alternate' type='text/html' href='http://git.dieschoenewolke.de/janschoenfeld/checkout.git/commit/?id=10e37f5ca370a159eb6364bd241689e58d844f91'/>
<id>10e37f5ca370a159eb6364bd241689e58d844f91</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>changes to support ghes alpha release (#199)</title>
<updated>2020-03-25T19:12:22+00:00</updated>
<author>
<name>eric sciple</name>
<email>ericsciple@users.noreply.github.com</email>
</author>
<published>2020-03-25T19:12:22+00:00</published>
<link rel='alternate' type='text/html' href='http://git.dieschoenewolke.de/janschoenfeld/checkout.git/commit/?id=18fd0bc59958dd73f02ac7a98cb5995f83e6f1de'/>
<id>18fd0bc59958dd73f02ac7a98cb5995f83e6f1de</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>persist core.sshCommand for submodules (#184)</title>
<updated>2020-03-12T15:42:38+00:00</updated>
<author>
<name>eric sciple</name>
<email>ericsciple@users.noreply.github.com</email>
</author>
<published>2020-03-12T15:42:38+00:00</published>
<link rel='alternate' type='text/html' href='http://git.dieschoenewolke.de/janschoenfeld/checkout.git/commit/?id=6f1b729011b34bc28608462b6293df85180aba9c'/>
<id>6f1b729011b34bc28608462b6293df85180aba9c</id>
<content type='text'>
* persist core.sshCommand for submodules

* update verbiage; add comments

* fail when submodules or ssh-key and fallback to REST API</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
* persist core.sshCommand for submodules

* update verbiage; add comments

* fail when submodules or ssh-key and fallback to REST API</pre>
</div>
</content>
</entry>
<entry>
<title>add ssh support (#163)</title>
<updated>2020-03-11T19:55:17+00:00</updated>
<author>
<name>eric sciple</name>
<email>ericsciple@users.noreply.github.com</email>
</author>
<published>2020-03-11T19:55:17+00:00</published>
<link rel='alternate' type='text/html' href='http://git.dieschoenewolke.de/janschoenfeld/checkout.git/commit/?id=1b406b27feed694fb3a05a638c92124514baa6ea'/>
<id>1b406b27feed694fb3a05a638c92124514baa6ea</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>convert SSH URL to HTTPS (#179)</title>
<updated>2020-03-10T14:45:50+00:00</updated>
<author>
<name>eric sciple</name>
<email>ericsciple@users.noreply.github.com</email>
</author>
<published>2020-03-10T14:45:50+00:00</published>
<link rel='alternate' type='text/html' href='http://git.dieschoenewolke.de/janschoenfeld/checkout.git/commit/?id=ad8315eb967265115b59c3b9dc1516f8ac5917ba'/>
<id>ad8315eb967265115b59c3b9dc1516f8ac5917ba</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>add support for submodules (#173)</title>
<updated>2020-03-05T19:21:59+00:00</updated>
<author>
<name>eric sciple</name>
<email>ericsciple@users.noreply.github.com</email>
</author>
<published>2020-03-05T19:21:59+00:00</published>
<link rel='alternate' type='text/html' href='http://git.dieschoenewolke.de/janschoenfeld/checkout.git/commit/?id=7ca5766bfacc6c307d7e69645aa94ac44318af46'/>
<id>7ca5766bfacc6c307d7e69645aa94ac44318af46</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>more unit tests and corresponding refactoring (#174)</title>
<updated>2020-03-02T16:33:30+00:00</updated>
<author>
<name>eric sciple</name>
<email>ericsciple@users.noreply.github.com</email>
</author>
<published>2020-03-02T16:33:30+00:00</published>
<link rel='alternate' type='text/html' href='http://git.dieschoenewolke.de/janschoenfeld/checkout.git/commit/?id=684bbf983233d1341d533f6fe471109f385c631a'/>
<id>684bbf983233d1341d533f6fe471109f385c631a</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
</feed>
